standard-tests[patch]: require model_name in response_metadata if returns_usage_metadata #30497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
size:M
|
cc @mattf |
mattf
added a commit
to mattf/langchain-llama-stack
that referenced
this pull request
Mar 26, 2025
ccurme
added a commit
to langchain-ai/langchain-aws
that referenced
this pull request
Mar 27, 2025
Largely to support tracking token usage across models via a new [usage metadata callback handler](https://python.langchain.com/docs/how_to/chat_token_usage_tracking/#using-callbacks). Standard tests were updated to enforce compatibility in langchain-ai/langchain#30497. Here we update `langchain-tests` to pick up the new test and update ChatBedrock and ChatBedrockConverse to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are implementing a token-counting callback handler in
langchain-corethat is intended to work with all chat models supporting usage metadata. The callback will aggregate usage metadata by model. This requires responses to include the model name in its metadata.To support this, if a model
returns_usage_metadata, we check that it includes a string model name in itsresponse_metadatain the"model_name"key.More context: #30487