Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Enable max_retries Parameter in ChatMistralAI Class #30448

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Fix: Enable max_retries Parameter in ChatMistralAI Class #30448

merged 1 commit into from
Mar 27, 2025

Conversation

andrasfe
Copy link
Contributor

@andrasfe andrasfe commented Mar 23, 2025 •
edited
Loading

partners: Enable max_retries in ChatMistralAI

Description

  • This pull request reactivates the retry logic in the completion_with_retry method of the ChatMistralAI class, restoring the intended functionality of the previously ineffective max_retries parameter. New unit test that mocks failed/successful retry calls and an integration test to confirm end-to-end functionality.

Issue

Dependencies

  • No additional dependencies required

@vercel Vercel
Copy link

vercel bot commented Mar 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 23, 2025 4:34pm

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Mar 23, 2025
@andrasfe
Copy link
Contributor Author

@ccurme , can you please review this PR? I found that simply un-commenting the retry functionality solved the issue while I couldn't find any downside. Added unit tests as well. ty

ccurme
ccurme approved these changes Mar 27, 2025
View reviewed changes
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 27, 2025
@ccurme ccurme merged commit 63673b7 into langchain-ai:master Mar 27, 2025
30 checks passed
@andrasfe andrasfe deleted the Fix-Enable-max_retries-Parameter-in-ChatMistralAI-Class branch April 1, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccurme ccurme ccurme approved these changes

Assignees
No one assigned
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PR looks good. Use to confirm that a PR is ready for merging. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

max_retries Parameter in ChatMistralAI Class Is Ineffective Due to Commented Code
2 participants
@andrasfe @ccurme