Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect import path for AzureAIChatCompletionsModel #30417

Merged

Conversation

csanz91
Copy link
Contributor

@csanz91 csanz91 commented Mar 21, 2025

Fixes #30416

Correct the import path for AzureAIChatCompletionsModel in the _init_chat_model_helper function.

  • Update the import statement in libs/langchain/langchain/chat_models/base.py to from langchain_azure_ai.chat_models import AzureAIChatCompletionsModel.

For more details, open the Copilot Workspace session.

Copy link

vercel bot commented Mar 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2025 7:58pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. langchain Related to the langchain package 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Mar 21, 2025
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marlenezw
Copy link
Contributor

Ugh, thanks for the catch! This LGTM!

@marlenezw
Copy link
Contributor

I also noticed that in line 111 in the docstring, I made a mistake. it should be
'azure_ai -> langchain-azure-ai'
it's currently langchain-ai in the second bit. Can we update that too in this PR ?

csanz91 added 2 commits March 21, 2025 20:58
Fixes langchain-ai#30416

Correct the import path for `AzureAIChatCompletionsModel` in the `_init_chat_model_helper` function.

* Update the import statement in `libs/langchain/langchain/chat_models/base.py` to `from langchain_azure_ai.chat_models import AzureAIChatCompletionsModel`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/langchain-ai/langchain/issues/30416?shareId=XXXX-XXXX-XXXX-XXXX).
@csanz91 csanz91 force-pushed the fix-langchain_azure_ai-import-path branch from a89f8bf to 1b783a5 Compare March 21, 2025 19:58
@marlenezw
Copy link
Contributor

This looks great! Thank you!!

@csanz91 csanz91 requested a review from ccurme March 21, 2025 20:30
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 22, 2025
@ccurme ccurme merged commit 5383abf into langchain-ai:master Mar 22, 2025
31 checks passed
@csanz91 csanz91 deleted the fix-langchain_azure_ai-import-path branch March 22, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
langchain Related to the langchain package lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect import path for AzureAIChatCompletionsModel in the _init_chat_model_helper call
3 participants