Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add tool_call exclusion in filter_message #30289

Merged
merged 4 commits into from
Mar 21, 2025

Conversation

ianchi
Copy link
Contributor

@ianchi ianchi commented Mar 14, 2025

Extend functionallity to allow to filter pairs of tool calls (ai + tool).

Copy link

vercel bot commented Mar 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2025 10:57pm

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 14, 2025
Copy link
Contributor

@vbarda vbarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! could you please add some unittests?

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Mar 17, 2025
@ianchi
Copy link
Contributor Author

ianchi commented Mar 17, 2025

Hi @vbarda I've updated the code addressing the comments.

Please, some help checking the Anthropic one, as I'm not familiar with it.

@ianchi ianchi force-pushed the filter_message branch 2 times, most recently from ac62b44 to 5c7d703 Compare March 18, 2025 01:21
@vbarda
Copy link
Contributor

vbarda commented Mar 18, 2025

Hi @vbarda I've updated the code addressing the comments.

Please, some help checking the Anthropic one, as I'm not familiar with it.

Sounds good, will update this later this week!

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Mar 21, 2025
Copy link
Contributor

@vbarda vbarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 21, 2025
@vbarda vbarda enabled auto-merge (squash) March 21, 2025 22:59
@vbarda vbarda merged commit b75573e into langchain-ai:master Mar 21, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants