feat(BA-997): Add image purge CLI command for hard deleting ImageRow
#3951
+128
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size:M
jopemachine
changed the title
forget CLI commandforget CLI command
jopemachine
changed the title
forget CLI commandforget CLI command
jopemachine
changed the title
forget CLI commandforget CLI command
jopemachine
changed the title
forget CLI commandimage purge CLI command for hard deleting ImageRow
github-actions
bot
added
size:L
jopemachine
force-pushed
the
fix/wrong-forget-cli-impl
branch
from
d1fdd5c to
8c373c2
Compare
jopemachine
commented
Mar 12, 2025
jopemachine
added
comp:client
src/ai/backend/client/cli/image.py
Outdated
Comment on lines
122
to
127
| if remove_from_registry: | ||
| result = session.Image.untag_image_from_registry(image_id) | ||
| if not result["ok"]: | ||
| print_fail("Image untag has failed: {0}".format(result["msg"])) | ||
| sys.exit(ExitCode.FAILURE) | ||
| session.Image.purge_image_by_id(image_id) |
There was a problem hiding this comment.
I guess it should be managed as a transaction, but is it okay if only one of the actions (remove_from_registry, purge_image_by_id) executes and the other fails?
There was a problem hiding this comment.
If untag_image_from_registry succeeds but purge_image_by_id fails, an inappropriate ImageRow will remain in the images table.
Unless the purge_image mutation is explicitly called for the corresponding ImageRow, it will continue to exist.
Ideally, a soft deletion process should be added during the image rescan to handle images that have already been removed from the registry.
See BA-969 for this
jopemachine
force-pushed
the
fix/wrong-forget-cli-impl
branch
from
717e305 to
4ed0f77
Compare
github-actions
bot
added
size:L
jopemachine
commented
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3979 (BA-997).
Checklist: (if applicable)
📚 Documentation preview 📚: https://sorna--3951.org.readthedocs.build/en/3951/
📚 Documentation preview 📚: https://sorna-ko--3951.org.readthedocs.build/ko/3951/