Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup envtests in CRA #18240

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Setup envtests in CRA #18240

merged 1 commit into from
Sep 27, 2023

Conversation

VOID404
Copy link
Contributor

@VOID404 VOID404 commented Sep 27, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Setup envtest in the Makefile

Related issue(s)

@VOID404 VOID404 requested a review from a team as a code owner September 27, 2023 12:11
@netlify
Copy link

netlify bot commented Sep 27, 2023

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit bd86288

@netlify
Copy link

netlify bot commented Sep 27, 2023 •
edited
Loading

✅ Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit bd86288
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/65141c0542f7be0008aed883
😎 Deploy Preview https://deploy-preview-18240--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 27, 2023
@VOID404 VOID404 mentioned this pull request Sep 27, 2023
Merged
@VOID404
Copy link
Contributor Author

VOID404 commented Sep 27, 2023

related PR in test-infra:
kyma-project/test-infra#8969

koala7659
koala7659 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 27, 2023
@kyma-bot kyma-bot merged commit 89d6c8d into kyma-project:main Sep 27, 2023
@Disper Disper added the area/application-connector Issues or PRs related to application connectivity label Oct 26, 2023
@Disper Disper added this to the 2.20 milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koala7659 koala7659 koala7659 approved these changes

Assignees

@koala7659 koala7659

Labels
area/application-connector Issues or PRs related to application connectivity lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
2.20
Development

Successfully merging this pull request may close these issues.
4 participants
@VOID404 @koala7659 @Disper @kyma-bot