-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(e2e): improve universal app run #13033
Open
lahabana
wants to merge
7
commits into
master
Choose a base branch
from
betterDebug
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer Checklist🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
|
Rely on constant ssh connection and make things easier to get report out Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It was very hard to have a complete and readable state of things in the test report because we were executing one of ssh cmds in different places.
We now keep a persistent ssh session for the whole time of the app which makes things easier to track and the output easier to consume.
Implementation information
the ssh package was completely redesigned to keep an ssh session rather than forking to execute
ssh
commands. This makes things easier to follow, easier to write lengthy scripts without caring about escaping things correctly for bash.Once this was done we could start a CP or run a DP with a single cmdLine instead of a list of complex calls.
This makes the report a lot easier as it avoids a lot of noisy stuff.
Other minor changes:
Supporting documentation
Fix 13123