Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): improve universal app run #13033

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

test(e2e): improve universal app run #13033

wants to merge 7 commits into from

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Mar 7, 2025

Motivation

It was very hard to have a complete and readable state of things in the test report because we were executing one of ssh cmds in different places.
We now keep a persistent ssh session for the whole time of the app which makes things easier to track and the output easier to consume.

Implementation information

the ssh package was completely redesigned to keep an ssh session rather than forking to execute ssh commands. This makes things easier to follow, easier to write lengthy scripts without caring about escaping things correctly for bash.
Once this was done we could start a CP or run a DP with a single cmdLine instead of a list of complex calls.

This makes the report a lot easier as it avoids a lot of noisy stuff.

Other minor changes:

  • Stop doing retries inside the framework. Either we should retry because it's setup or simply in an eventually. Also stop using the retry from terratest as it's very verbose.
  • ignore for dockerfiles were including things that were not necessary, this made the building of images longer.
  • Once this change was done we could run into clock skews with tokens. So moved the token issuance date a few seconds in the past

Supporting documentation

Fix 13123

@lahabana lahabana added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Mar 7, 2025
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

@lahabana lahabana changed the title test(e2e): Improve universal app run test(e2e): improve universal app run Mar 13, 2025
Rely on constant ssh connection and make things easier to get report out

Signed-off-by: Charly Molter <[email protected]>
Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana marked this pull request as ready for review March 19, 2025 13:10
@lahabana lahabana requested a review from a team as a code owner March 19, 2025 13:10
@lahabana lahabana requested review from slonka and Icarus9913 March 19, 2025 13:10
@lahabana lahabana self-assigned this Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant