Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oapi): fix default in size query parameter #12936

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Feb 24, 2025

Motivation

It's just wrong and causes failures upstream.

Implementation information

Put it in the right place - https://swagger.io/docs/specification/v3_0/describing-parameters/#default-parameter-values

xrel: #12935

Changelog: feat(openapi): generate a spec with all resources

@slonka slonka added the ci/skip-e2e-test PR: Don't run e2e tests label Feb 24, 2025
@slonka slonka requested a review from a team as a code owner February 24, 2025 18:03
@slonka slonka requested review from lukidzi and Icarus9913 February 24, 2025 18:03
Copy link
Contributor

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

@slonka slonka merged commit 3ab8d8d into kumahq:master Feb 24, 2025
13 checks passed
kumahq bot pushed a commit that referenced this pull request Mar 13, 2025
kumahq bot pushed a commit that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-e2e-test PR: Don't run e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants