vSphere: ignore canceled VMs when scheduling #1465
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the migration runner attempts to schedule as many VMs as it can in a single reconcilation, it has exposed a bug in the scheduler where canceled VMs are rescheduled endlessly in certain pathological cases, preventing the reconciliation from terminating. (for instance, if a VM is canceled before it has been marked started, it will always appear ready to schedule although there is nothing for the plan controller to do with it.) The endless rescheduling causes the controller to infinite loop and be unable to reconcile resources, necessitating that the offending Migration resource be deleted and the controller pod be restarted. Checking for the `Canceled` condition on the VM is adequate to prevent the problem. (Requesting cancelation of the VM via the Migration resource will cause the VM to be marked with the Canceled condition in memory as the Plan is reconciled, which will cause it to be ignored by the scheduler, and on the following reconcile it will be cleaned up as intended.) Signed-off-by: Sam Lucidi <[email protected]>
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1465 +/- ##
==========================================
- Coverage 15.45% 15.14% -0.32%
==========================================
Files 112 113 +1
Lines 23377 24351 +974
==========================================
+ Hits 3613 3687 +74
- Misses 19479 20376 +897
- Partials 285 288 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the migration runner attempts to schedule as many VMs as it can in a single reconcilation,
it has exposed a bug in the scheduler where canceled VMs are rescheduled endlessly in certain pathological cases, preventing the reconciliation from terminating.
(for instance, if a VM is canceled before it has been marked started, it will always appear ready to schedule although there is nothing for the plan controller to do with it.)
The endless rescheduling causes the controller to infinite loop and be unable to reconcile resources, necessitating that the offending Migration resource be deleted and the controller pod be restarted.
Checking for the
Canceledcondition on the VM is adequate to prevent the problem. (Requesting cancelation of the VM via the Migration resource will cause the VM to be marked with the Canceled condition in memory as the Plan is reconciled, which will cause it to be ignored by the scheduler, and on the following reconcile it will be cleaned up as intended.)