Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ReserveQuotaAt instead of ReserveQuota on unit tests #4476

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Mar 4, 2025

What type of PR is this?

/kind bug
/kind flake

What this PR does / why we need it:

Use ReserveQuotaAt instead of ReserveQuotaAt on unit tests.

Which issue(s) this PR fixes:

Fixes #4425

Special notes for your reviewer:

Currently we are using ReserveQuota() function that using time.Now() to set LastTransitionTime. We need to use time.Now() from test.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. labels Mar 4, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 4, 2025
Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 8122517
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67c71c6b3bac0100089a4ec4
😎 Deploy Preview https://deploy-preview-4476--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mbobrovskyi
Copy link
Contributor Author

/retest

@mimowo
Copy link
Contributor

mimowo commented Mar 4, 2025

/retitle Use ReserveQuotaAt instead of ReserveQuota on unit tests

@k8s-ci-robot k8s-ci-robot changed the title Use ReserveQuotaAt instead of ReserveQuotaAt on unit tests. Use ReserveQuotaAt instead of ReserveQuota on unit tests Mar 4, 2025
@mimowo
Copy link
Contributor

mimowo commented Mar 4, 2025

/lgtm
/approve
/cherry-pick release-0.10 release-0.9
To make the release branches more stable

@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: once the present PR merges, I will cherry-pick it on top of release-0.10 in a new PR and assign it to you.

In response to this:

/lgtm
/approve
/cherry-pick release-0.10 release-0.9
To make the release branches more stable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cd62619f132ef4fe7d71aa4614c2609598f280f4

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2025
@k8s-ci-robot k8s-ci-robot merged commit cd747db into kubernetes-sigs:main Mar 4, 2025
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.11 milestone Mar 4, 2025
@mimowo
Copy link
Contributor

mimowo commented Mar 4, 2025

/cherry-pick release-0.10 release-0.9

@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: new pull request created: #4478

In response to this:

/lgtm
/approve
/cherry-pick release-0.10 release-0.9
To make the release branches more stable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link
Contributor

@mimowo: new pull request could not be created: failed to create pull request against kubernetes-sigs/kueue#release-0.10 from head k8s-infra-cherrypick-robot:cherry-pick-4476-to-release-0.10: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for k8s-infra-cherrypick-robot:cherry-pick-4476-to-release-0.10."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherry-pick release-0.10 release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mbobrovskyi mbobrovskyi deleted the fix/preempt-newer-workloads-with-the-same-priority branch March 4, 2025 17:20
kannon92 pushed a commit to openshift/kubernetes-sigs-kueue that referenced this pull request Mar 13, 2025
kannon92 pushed a commit to openshift/kubernetes-sigs-kueue that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky unit test] TestPreemption/preempt_newer_workloads_with_the_same_priority
4 participants