-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ReserveQuotaAt instead of ReserveQuota on unit tests #4476
Use ReserveQuotaAt instead of ReserveQuota on unit tests #4476
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/retest |
/retitle Use ReserveQuotaAt instead of ReserveQuota on unit tests |
/lgtm |
@mimowo: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
LGTM label has been added. Git tree hash: cd62619f132ef4fe7d71aa4614c2609598f280f4
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbobrovskyi, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.10 release-0.9 |
@mimowo: new pull request created: #4478 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@mimowo: new pull request could not be created: failed to create pull request against kubernetes-sigs/kueue#release-0.10 from head k8s-infra-cherrypick-robot:cherry-pick-4476-to-release-0.10: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for k8s-infra-cherrypick-robot:cherry-pick-4476-to-release-0.10."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
/kind flake
What this PR does / why we need it:
Use ReserveQuotaAt instead of ReserveQuotaAt on unit tests.
Which issue(s) this PR fixes:
Fixes #4425
Special notes for your reviewer:
Currently we are using ReserveQuota() function that using time.Now() to set LastTransitionTime. We need to use time.Now() from test.
Does this PR introduce a user-facing change?