Move Pod labels and annotation to separate package.

[mbobrovskyi]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Move Pod labels and annotation to separate package.

Which issue(s) this PR fixes:

Part of #3653

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	63b67ec
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67c6d9f921e99f0008c00274

[mbobrovskyi]

/cc @PBundyra

[tenzen-y]

If we put these constants in pkg/controller/jobs/pod, there are cycle imports, right?
If yes, could you point out the place for cycle imports?

[mbobrovskyi]

I updated the labels and annotations in pkg/util/testingjobs/pod/wrappers.go to use constants instead:

kueue/pkg/util/testingjobs/pod/wrappers.go

Lines 158 to 170 in d677d9e

	func (p *PodWrapper) PodGroupServingAnnotation(enabled bool) *PodWrapper {
	return p.Annotation("kueue.x-k8s.io/pod-group-serving", strconv.FormatBool(enabled))
	}
	// RoleHash updates the pod.RoleHashAnnotation of the pod
	func (p *PodWrapper) RoleHash(h string) *PodWrapper {
	return p.Annotation("kueue.x-k8s.io/role-hash", h)
	}
	// KueueSchedulingGate adds kueue scheduling gate to the Pod
	func (p *PodWrapper) KueueSchedulingGate() *PodWrapper {
	return p.Gate("kueue.x-k8s.io/admission")
	}

However, this introduced circular dependencies. To resolve this, I moved the code into a separate package.

[tenzen-y]

That sounds reasonable.

[tenzen-y]

What is the cause for these manifest changes?

[mbobrovskyi]

I didn't change +kubebuilder markers. I think it happens after moving constants to separate package.

[mbobrovskyi]

From what I can see, the changes only involve reordering the code.

[tenzen-y]

Interesting. Anyway, it seems not to change manifests except for orders.

[tenzen-y]

Thank you!
/lgtm
/approve

[tenzen-y]

That sounds reasonable.

[tenzen-y]

Interesting. Anyway, it seems not to change manifests except for orders.

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 48d4a423ce61a43877767afb270531158aa6317c

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment