Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize TestSlurmBuilderDo. #87

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimize TestSlurmBuilderDo. #87

wants to merge 1 commit into from
+224 −169

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Mar 21, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Optimize TestSlurmBuilderDo to avoid code duplication.

Which issue(s) this PR fixes:

Prepare for #76

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mbobrovskyi
Once this PR has been reviewed and has the lgtm label, please assign mwielgus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from mimowo and mwielgus March 21, 2025 11:49
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 21, 2025
@mbobrovskyi
Copy link
Contributor Author

/cc @IrvingMg

@k8s-ci-robot k8s-ci-robot requested a review from IrvingMg March 21, 2025 11:50
@mbobrovskyi
Copy link
Contributor Author

/hold for #88

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2025
@mbobrovskyi mbobrovskyi mentioned this pull request Mar 21, 2025
Open
@mbobrovskyi mbobrovskyi force-pushed the cleanup/optimize-slurm-builder-test branch from d947eb5 to 9495f26 Compare March 21, 2025 12:15
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2025
@mbobrovskyi mbobrovskyi force-pushed the cleanup/optimize-slurm-builder-test branch from 9495f26 to a9b2444 Compare March 21, 2025 18:59
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2025
@mbobrovskyi
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo Awaiting requested review from mimowo

@mwielgus mwielgus Awaiting requested review from mwielgus

@IrvingMg IrvingMg Awaiting requested review from IrvingMg

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbobrovskyi @k8s-ci-robot