Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missed Flag enum values #85

Merged

Conversation

mbobrovskyi
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Add missed Flag enum values

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

The ApplicationProfile "slurm-profile" is invalid: 
* spec.supportedModes[0].requiredFlags[0]: Unsupported value: "time": supported values: "cmd", "parallelism", "completions", "replicas", "min-replicas", "max-replicas", "request", "localqueue", "raycluster", "array", "cpus-per-task", "error", "gpus-per-task", "input", "job-name", "mem-per-cpu", "mem-per-gpu", "mem-per-task", "nodes", "ntasks", "output", "partition"
* spec.supportedModes[0].requiredFlags[1]: Unsupported value: "priority": supported values: "cmd", "parallelism", "completions", "replicas", "min-replicas", "max-replicas", "request", "localqueue", "raycluster", "array", "cpus-per-task", "error", "gpus-per-task", "input", "job-name", "mem-per-cpu", "mem-per-gpu", "mem-per-task", "nodes", "ntasks", "output", "partition"
* <nil>: Invalid value: "null": some validation rules were not checked because the object was invalid; correct the existing errors to complete validation

Does this PR introduce a user-facing change?

Fixed bug that doesn't allow to add priority and time to requiredFlags.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Mar 21, 2025
@k8s-ci-robot k8s-ci-robot requested a review from mimowo March 21, 2025 10:30
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 21, 2025
@k8s-ci-robot k8s-ci-robot requested a review from mwielgus March 21, 2025 10:30
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 21, 2025
@mbobrovskyi
Copy link
Contributor Author

/cherry-pick release-0.1

@k8s-infra-cherrypick-robot

@mbobrovskyi: once the present PR merges, I will cherry-pick it on top of release-0.1 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mbobrovskyi
Copy link
Contributor Author

/cc @IrvingMg

@k8s-ci-robot k8s-ci-robot requested a review from IrvingMg March 21, 2025 10:37
@mbobrovskyi mbobrovskyi force-pushed the fix/add-missed-enum-values branch from ca7bbd0 to 60ac384 Compare March 21, 2025 12:34
@mbobrovskyi mbobrovskyi force-pushed the fix/add-missed-enum-values branch from 60ac384 to 2d99890 Compare March 21, 2025 12:35
@IrvingMg
Copy link
Contributor

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 384fd926f1d665f760720c9d3cb41754ce86d297

@mimowo
Copy link
Contributor

mimowo commented Mar 24, 2025

/approve
Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit d2ad256 into kubernetes-sigs:main Mar 24, 2025
6 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.2 milestone Mar 24, 2025
@k8s-infra-cherrypick-robot

@mbobrovskyi: #85 failed to apply on top of branch "release-0.1":

Applying: Add missed Flag enum values.
warning: Cannot merge binary files: pkg/cmd/printcrds/embed/manifest.gz (HEAD vs. Add missed Flag enum values.)
Using index info to reconstruct a base tree...
M	apis/v1alpha1/application_profile_types.go
M	config/crd/bases/kjobctl.x-k8s.io_applicationprofiles.yaml
M	pkg/cmd/printcrds/embed/manifest.gz
Falling back to patching base and 3-way merge...
Auto-merging pkg/cmd/printcrds/embed/manifest.gz
CONFLICT (content): Merge conflict in pkg/cmd/printcrds/embed/manifest.gz
Auto-merging config/crd/bases/kjobctl.x-k8s.io_applicationprofiles.yaml
Auto-merging apis/v1alpha1/application_profile_types.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Add missed Flag enum values.

In response to this:

/cherry-pick release-0.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mbobrovskyi mbobrovskyi deleted the fix/add-missed-enum-values branch March 24, 2025 08:13
mbobrovskyi added a commit to mbobrovskyi/kjob that referenced this pull request Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants