-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container-name flag #68
Conversation
Signed-off-by: Piotr Pawłowski <[email protected]>
Welcome @pawloch00! |
Hi @pawloch00. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Piotr Pawłowski <[email protected]>
/ok-to-test |
/kind feature |
Signed-off-by: Piotr Pawłowski <[email protected]>
Signed-off-by: Piotr Pawłowski <[email protected]>
Signed-off-by: Piotr Pawłowski <[email protected]>
Signed-off-by: Piotr Pawłowski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be also great to add e2e test.
Signed-off-by: Piotr Pawłowski <[email protected]>
Signed-off-by: Piotr Pawłowski <[email protected]>
Signed-off-by: Piotr Pawłowski <[email protected]>
Signed-off-by: Piotr Pawłowski <[email protected]>
Signed-off-by: Piotr Pawłowski <[email protected]>
Signed-off-by: Piotr Pawłowski <[email protected]>
Signed-off-by: Piotr Pawłowski <[email protected]>
Signed-off-by: Piotr Pawłowski <[email protected]>
Created PR #77 for follow up E2E tests. |
/lgtm Thank you so much for your efforts. |
LGTM label has been added. Git tree hash: 83a37566ef6eca66d23a7d18aa61209ff6c21fde
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🖖
/cc @mimowo |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo, mwysokin, pawloch00 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
This PR introduces new flag for running jobs with online output
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?