-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip preflight and remove Kubernetes < 1.13 workarounds / code #1744
Conversation
we already depend on 1.13+ features now. 1.19 is releasing soon and 1.13 is nearing two years old. upstream only supports 1.16+
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/lgtm
/hold
/hold cancel |
This might have broken kind for us:
|
We're currently dropping support for Kubernetes versions without this functionality upstream, it seems this works in single node clusters but not multi-node in 1.13, which was an oversight in the release notes. It appears that while 1.13 has this flag, it only has it in |
Sorry about that, we should have tested this, shoring up the CI and policy around older versions is something we're looking at this quarter. I've updated the release notes. Officially the Kubernetes project will not support a release this old, kind supports older releases best-effort currently but only 1.17+ are open for patches / support upstream. https://kubernetes.io/docs/setup/release/version-skew-policy/#:~:text=Supported%20versions&text=The%20Kubernetes%20project%20maintains%20release,9%20months%20of%20patch%20support. |
This will enable us to control the pause image to match containerd as well (in a future change)
Upstream Kubernetes only supports 1.16+ currently. 1.13 came out December 2018.
1.13+ enables skipping phases, and narrows down the kubeadm config to beta versions only (v1beta1 and v1beta2).
It also enables us to remove some build workarounds related to changes around Kubernetes 1.12.