Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip preflight and remove Kubernetes < 1.13 workarounds / code #1744

Merged
merged 2 commits into from
Jul 23, 2020

Conversation

BenTheElder
Copy link
Member

This will enable us to control the pause image to match containerd as well (in a future change)

Upstream Kubernetes only supports 1.16+ currently. 1.13 came out December 2018.
1.13+ enables skipping phases, and narrows down the kubeadm config to beta versions only (v1beta1 and v1beta2).
It also enables us to remove some build workarounds related to changes around Kubernetes 1.12.

we already depend on 1.13+ features now. 1.19 is releasing soon and 1.13 is nearing two years old.

upstream only supports 1.16+
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 23, 2020
@k8s-ci-robot k8s-ci-robot requested review from amwat and munnerz July 23, 2020 00:07
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 23, 2020
@BenTheElder
Copy link
Member Author

/retest
pod pending timeout

@BenTheElder
Copy link
Member Author

/retest

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2020
@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5c4a5ad into kubernetes-sigs:master Jul 23, 2020
@BenTheElder BenTheElder deleted the yolo-flight branch July 23, 2020 01:07
@BenTheElder BenTheElder mentioned this pull request Aug 13, 2020
@FraBle
Copy link

FraBle commented Sep 15, 2020

This might have broken kind for us:

Creating cluster "skynet" ...
 ✓ Ensuring node image (kindest/node:v1.13.12) 🖼
 ✓ Preparing nodes 📦 📦 📦 📦
 ✓ Writing configuration 📜
 ✓ Starting control-plane 🕹️
 ✓ Installing CNI 🔌
 ✓ Installing StorageClass 💾
 ✗ Joining worker nodes 🚜
ERROR: failed to create cluster: failed to join node with kubeadm: command "docker exec --privileged skynet-worker kubeadm join --config /kind/kubeadm.conf --skip-phases=preflight --v=6" failed with error: exit status 1
Command Output: Error: unknown flag: --skip-phases

@BenTheElder
Copy link
Member Author

We're currently dropping support for Kubernetes versions without this functionality upstream, it seems this works in single node clusters but not multi-node in 1.13, which was an oversight in the release notes.

It appears that while 1.13 has this flag, it only has it in kubeadm init and not kubeadm join, whereas 1.14+ has it in both.
I will add a breaking change note to the release notes for now. In the future we may have an alternative workaround.

@BenTheElder
Copy link
Member Author

Sorry about that, we should have tested this, shoring up the CI and policy around older versions is something we're looking at this quarter. I've updated the release notes.

Officially the Kubernetes project will not support a release this old, kind supports older releases best-effort currently but only 1.17+ are open for patches / support upstream. https://kubernetes.io/docs/setup/release/version-skew-policy/#:~:text=Supported%20versions&text=The%20Kubernetes%20project%20maintains%20release,9%20months%20of%20patch%20support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants