Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command module issues in kube-vip playbook #1489

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

ErikJiang
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

When using the command module to execute commands, 'command' should not appear in the command itself to avoid execution errors.

This PR updates the command execution to prevent duplicate 'command' occurrences.

Which issue(s) this PR fixes:

Fixes #1485

Special notes for your reviewer:

@ErikJiang ErikJiang requested a review from 0ekk February 26, 2025 03:21
@ErikJiang ErikJiang added kind/bug Categorizes issue or PR as related to a bug. bug labels Feb 26, 2025
@0ekk
Copy link
Member

0ekk commented Feb 27, 2025

/lgtm

@ErikJiang ErikJiang merged commit 8289563 into kubean-io:main Feb 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
2 participants