Bump observability stack #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump go (1.16 -> 1.18) * Bump otel (0.16.0 -> 1.7.0 / 0.30.0) A lot of stuff we used have been moved around. Traces are now stable in otel so we can expect this to stay still; metrics are still in alpha though so compat may break again in the future. Notables changes: * metric.Must has been removed; some constructors now have their signature changed. We can introduce a custom Must so we don't change those signatures * metric.Bind has been removed from the metrics package. That introduces a little more complexity to the code. I understood that (open-telemetry/opentelemetry-go#2351) it might be reintroduced in the future
nicoche
commented
May 2, 2022
| count := m.NewInt64Counter("kreconciler_stream_resync_item_count", | ||
| metric.WithUnit(unit.Dimensionless), | ||
| metric.WithDescription("Increased by the number of items returned by the listFn"), | ||
| func ResyncLoopEventStream(obs Observability, duration time.Duration, listFn func(ctx context.Context) ([]string, error)) (EventStream, error) { |
There was a problem hiding this comment.
Note: we could panic on err so we don't change that prototype
bchatelard
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of stuff we used have been moved around. Traces are now stable in
otel so we can expect this to stay still; metrics are still in alpha
though so compat may break again in the future.
Notables changes:
signature changed. We can introduce a custom Must so we don't
change those signatures
a little more complexity to the code. I understood that
(Consider removing bound metric instrument support open-telemetry/opentelemetry-go#2351) it
might be reintroduced in the future