Better handling of event stream errors #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an individual event stream fails, the error is not properly propagated to the reconciler. The error is muted, and the reconciler continue to pull events from other stream without restarting or notifying the caller.
bchatelard
force-pushed
the
better-eventstream-error-handling
branch
from
ff0dd70 to
6d3bb07
Compare
bchatelard
changed the title
cancelStream when one of the stream is failing
novln
reviewed
Sep 15, 2021
lahabana
approved these changes
Sep 15, 2021
| c.workerWaitGroup.Wait() | ||
| c.Info("stopped workers...") | ||
| c.Info("stopped controller...") | ||
| close(errChan) |
There was a problem hiding this comment.
NIT:
Is there a specific motiviation for moving this into defer?
I find defer makes the code harder to read so I prefer to avoid it when possible (an err var might just make things work)
There was a problem hiding this comment.
The idea was to be able to return directly the error instead of storing and returning the error later (my previous version not commited).
controller.go
Outdated
| @@ -72,24 +88,19 @@ func (c *controller) Run(ctx context.Context) error { | |||
| err := stream.Subscribe(streamCtx, MeteredEventHandler(c.Observability.Meter, n, EventHandlerFunc(c.enqueue))) | |||
| if err != nil { | |||
| c.Error("Failed subscribing to stream", "error", err) | |||
There was a problem hiding this comment.
Nit: Maybe worth adding the streamId to the log message.
|
Thanks for the review, I improved the logging, and added a test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an individual event stream fails, the error is not properly propagated to the reconciler.
The error is muted, and the reconciler continue to pull events from other stream without restarting or notifying the caller.