🌱 Extract logger package #450
Conversation
Signed-off-by: Alejandro Brugarolas <[email protected]>
| var log *logr.Logger | ||
| var logrusLog *logrus.Logger | ||
|
|
||
| func InitLogger() { |
There was a problem hiding this comment.
We need the ability to use the log level to increase verbosity.
I am also curious why instead of logs on the objects, we are miving to global functions, not opposed, just wondering the reasoning.
There was a problem hiding this comment.
This PR is part of the work related to #249. Currently, the AnalyzeCommand struct is pretty big, and it's being passed around to most of the project's functions just because they need access to logging
In fact, I haven't yet moved the providers to a separate package precisely because they depend on the logger currently located within the AnalyzeCommand so its a circular dependency.
Another approach I can think of to separate the logger from AnalyzeCommand would be to modify each function to include an extra parameter for the logger.
And I saw that this was reccommended: https://pkg.go.dev/github.com/sirupsen/[email protected]#New
There was a problem hiding this comment.
A change to remove passing loggers around would impact alot of stuff and currently most analyzer-lsp structs take a logger.
Can you show some functions that need the logger?
No description provided.