Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builds) fix build exports for ESM #173

Merged
merged 1 commit into from
May 12, 2022
Merged

builds) fix build exports for ESM #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ For TODO between alpha and release, see https://github.com/knockout/tko/issues/1

## upcoming

- replace `objectLookup` with `Map` in `toJS` for O(n) instead of O(n²) computational complexity (#170 @brianmhunt)
- replace `objectLookup` with `Map` in `toJS` for O(n) instead of O(n²) computational complexity (#170 @felipesantoz)
- fix equality comparison for select option values (#155/#163 @danieldickison)
- fix identifier set_value in parser (#157/#161 @danieldickison)
- remove mustache from text/attr bindings by default (#156 @danieldickison)
- knockout function rewrite improvements (#156 @danieldickison)
- change parsing algorithm to Shunting Yard (#151 @danieldickison)
- Switch to `esbuild`
- Switch to `esbuild` (likely breaks existing imports/require/etc)
- add `preventDefault` to event handler bindings
- switch source to Typescript (but no types exported yet)
- change build.reference & build.knockout build export strategy
Expand Down
0 builds/knockout/src/index.js → builds/knockout/src/index.ts
View file
Open in desktop
File renamed without changes.
0 builds/reference/src/index.js → builds/reference/src/index.ts
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions tools/build.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ dist/index.js: $(src) package.json
--define:BUILD_VERSION='"${version}"' \
--sourcemap=external \
--outdir=dist/ \
$(src)
src/index.ts

# Build a CommonJS bundle, targetting ES6.
dist/index.cjs: $(src) package.json
Expand Down Expand Up @@ -75,7 +75,7 @@ dist/browser.min.js: $(src) package.json
--minify \
--sourcemap=external \
--outfile=$@ \
./src/index.js
./src/index.ts

repackage: $(tools_dir)/repackage.mjs ../../lerna.json
node $(tools_dir)/repackage.mjs
Expand Down