Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add golangci-lint #584

Merged
merged 8 commits into from
Jan 27, 2023
Merged

chore: add golangci-lint #584

merged 8 commits into from
Jan 27, 2023

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Jan 26, 2023 •
edited
Loading

Signed-off-by: Jorge Turrado [email protected]

Enable static checks for the code using pre-commit to manage execute all of them. Added checks are:

  • golancgi-lint
  • trailing-whitespace
  • detect-private-key
  • end-of-file-fixer
  • check-merge-conflict
  • mixed-line-ending

Checklist

Fixes #

@JorTurFer JorTurFer changed the title wip - chore: add golangci.lint chore: add golangci.lint Jan 26, 2023
@JorTurFer
wip - chore: add golangci.lint
7c9aac5 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
fix linting errors
0ee21aa 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
update workflow
bb3bb01 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
fix style
5a8c1f7 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
add make command
1915725 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
fix styles
1e918bd 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer JorTurFer marked this pull request as ready for review January 26, 2023 20:56
@JorTurFer JorTurFer requested a review from a team as a code owner January 26, 2023 20:56
@JorTurFer JorTurFer changed the title chore: add golangci.lint chore: add golangc-lint Jan 26, 2023
@JorTurFer JorTurFer changed the title chore: add golangc-lint chore: add golangci-lint Jan 26, 2023
@JorTurFer
fix test
ffe7d5a 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer
fix test
e0b95e0 
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer JorTurFer mentioned this pull request Jan 26, 2023
Closed
2 tasks
@JorTurFer JorTurFer added this to the v0.4.0 milestone Jan 26, 2023
@tomkerkhove tomkerkhove merged commit b5c41c8 into kedacore:main Jan 27, 2023
@JorTurFer JorTurFer deleted the add-golangci-lint branch January 27, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JorTurFer @tomkerkhove