add cpu mem stats #192
Merged
add cpu mem stats #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ii2day
force-pushed
the
pr/ii2day/resource
branch
from
ddd0971 to
49c42f0
Compare
Codecov Report
@@ Coverage Diff @@
## main #192 +/- ##
=======================================
Coverage 38.94% 38.94%
=======================================
Files 8 8
Lines 529 529
=======================================
Hits 206 206
Misses 318 318
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. |
weizhoublue
reviewed
Sep 11, 2023
weizhoublue
reviewed
Sep 11, 2023
pkg/resource/resource.go
Outdated
| func (r *usedResource) GetCPUMem() (uint64, float64) { | ||
| r.l.Lock() | ||
| defer r.l.Unlock() | ||
| return r.mem, r.cpu |
There was a problem hiding this comment.
这个锁还是要加 要不然会出现读的时候写入
There was a problem hiding this comment.
我是指 这样 写的代码 逻辑， return 的值 真的 锁得住么 ？还是脏读
defer 还是在 return 前 就 放锁了
lock
defer unlock
a = r.m
b = r.c
return a,b
weizhoublue
reviewed
Sep 11, 2023
ii2day
force-pushed
the
pr/ii2day/resource
branch
2 times, most recently
from
e37d9c1 to
f001105
Compare
ii2day
force-pushed
the
pr/ii2day/resource
branch
from
f001105 to
a96fdb2
Compare
|
（1）PR 描述中，对于新功能要有描述 |
ii2day
force-pushed
the
pr/ii2day/resource
branch
2 times, most recently
from
f472a62 to
4a89f7c
Compare
（1）已添加 |
weizhoublue
reviewed
Sep 14, 2023
|
文档中，应该体现这个问题： |
ii2day
force-pushed
the
pr/ii2day/resource
branch
from
4a89f7c to
1b0198c
Compare
已添加 |
weizhoublue
reviewed
Sep 19, 2023
ii2day
force-pushed
the
pr/ii2day/resource
branch
2 times, most recently
from
dd6c4ec to
b04ee37
Compare
Signed-off-by: ii2day <[email protected]>
ii2day
force-pushed
the
pr/ii2day/resource
branch
from
b04ee37 to
3befd30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature #202
每轮任务报告增加 cpu memory 使用量统计，方便根据测试需求设置 agent 的 resource