-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: add sidecar configuration e2e test #6208
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6208 +/- ##
==========================================
+ Coverage 47.87% 47.89% +0.01%
==========================================
Files 676 676
Lines 55978 55978
==========================================
+ Hits 26802 26810 +8
+ Misses 27423 27416 -7
+ Partials 1753 1752 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
other parts LGTM
Signed-off-by: zhzhuang-zju <[email protected]>
The CI is failed~ |
There was a timeout when creating the cluster, and it hadn't reached the stage of installing Karmada yet. Just retest it. /retest |
all done~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XiShanYongYe-Chang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Add sidecar configuration e2e test, protect the following two scenarios:
Which issue(s) this PR fixes:
Parts of #6138
Special notes for your reviewer:
Does this PR introduce a user-facing change?: