Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kaiax: fix duplicated init of gov module #270

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

yoomee1313
Copy link
Contributor

Proposed changes

  • The gov module was init twice and it leads deriveSha package to use different headerGovModule. So the the other logics(such as insertChain) and deriveSha package references different headergov.History and it causes the unexpected stop at apply block of deriveSha vote (apply block is a block one epoch past from governance block).

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@yoomee1313 yoomee1313 self-assigned this Mar 3, 2025
Co-authored-by: Chihyun Song <[email protected]>
@yoomee1313 yoomee1313 merged commit d29ef6e into kaiachain:dev Mar 4, 2025
9 checks passed
@yoomee1313 yoomee1313 deleted the fix-duplicated-gov-init branch March 4, 2025 04:28
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants