Feature/sse kms #107
Closed
Feature/sse kms #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
September 7, 2016 17:44
kahing
added a commit
that referenced
this pull request
Sep 12, 2016
also got rid of the --use and prefix --kms with --sse, and made --sse-kms imply --sse because it doesn't make sense otherwise refs #107
|
I squashed this and #106 and massaged it a little. Could you take a look and let me know what you think? |
|
This makes sense given that the --sse-kms string can be left as empty. |
kahing
added a commit
that referenced
this pull request
Sep 13, 2016
also got rid of the --use and prefix --kms with --sse, and made --sse-kms imply --sse because it doesn't make sense otherwise refs #107
|
merged via 55c235c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Issue #102
This builds on the PR for SSE-S3.
Adds two more options:
--use-kmsand--kms-key-idwith expanded options for server side encryption of objects in S3.--use-sseis specified.--use-kmsis given, then uses the KMS server-side encryption mode (SSE-KMS) but with the default, customer master key (CMK).--kms-key-idis specified in addition to--use-kmsit use use that specified KMS instead of the master key. Requires that the user that is connected to S3 via goofys has permission to access and use that KMS key.All three cases tested in basic fashion with small and large file sizes.