Enable more symbolic keys: F13-F19, ShiftLeft/Right/Del/Home/End/Tab #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandwalker
force-pushed
the
enable-more-symbolic-keys
branch
from
df4503f to
28337a3
Compare
jonas
reviewed
Jul 4, 2017
| Notes | ||
|
|
||
| - Tig reads keystrokes via ncurses and is subject to various limitations. See | ||
| 'ncurses(3x)' and 'terminfo(5)' (or termcap). |
|
Build failure is due to 2b384f6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with some doc cleanup.
Further additional symbolic keys are known to ncurses; this PR is limited to keys I happen to be able to generate under xterm and/or iTerm2.
<ShiftLeft>looks like a poor choice of interface at first glance, compared to something composable like<Shift><Left>. But these keys are not actually composable, at least as filtered through ncurses.Ncurses has a finite list of supported shifted keys, the majority of which will not be available for modern keyboards/emulators.
That might be somewhat more clear to the user if the names were changed to eg
<ShiftedLeft>.