Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set view->parent to NULL when view is closed. #478

Merged
merged 1 commit into from
Feb 20, 2016
Merged

Conversation

egnagflow
Copy link
Contributor

Fixes an issue where diff full screen diff view up/down navigation results
in moving the underlying commit rather than the diff line if the diff view
had been opened in split format (Enter key) before.

Fixes an issue where diff full screen diff view up/down navigation results
in moving the underlying commit rather than the diff line if the diff view
had been opened in split format (Enter key) before.
jonas added a commit that referenced this pull request Feb 20, 2016
Set view->parent to NULL when view is closed.
@jonas jonas merged commit 01c5649 into jonas:master Feb 20, 2016
@jonas
Copy link
Owner

jonas commented Feb 20, 2016

Thanks.

koutcher added a commit that referenced this pull request Dec 14, 2020
Rework #478 and #835. Keep special Up/Down keys behaviour when split
diff view is maximized with `O` but restore normal Up/Down keys
behaviour when switching to any view.

Closes #1053
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants