Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails when branch has = character #884

Closed
ixti opened this issue Jan 9, 2019 · 4 comments
Closed

Fails when branch has = character #884

ixti opened this issue Jan 9, 2019 · 4 comments

Comments

@ixti
Copy link

ixti commented Jan 9, 2019 •
edited
Loading

Steps to reproduce:

git checkout -b some@weird=branch-name
tig
koutcher added a commit to koutcher/tig that referenced this issue Jan 14, 2019
@koutcher
Fix parsing of git rev-parse output
ed785c3 
Closes jonas#884
@ujjawaldx
Copy link

ujjawaldx commented Feb 1, 2019 •
edited
Loading

it doesn't happen for me

@ixti
Copy link
Author

ixti commented Feb 1, 2019

Don't know how, but it's not failing for me now as well. Probably the problem was in my shell o_O

@ixti ixti closed this as completed Feb 1, 2019
@ixti
Copy link
Author

ixti commented Feb 1, 2019

In fact it still fails. I just forgot to properly describe failure :D

@ixti ixti reopened this Feb 1, 2019
@ixti
Copy link
Author

ixti commented Feb 1, 2019

Here's how it looks:

https://asciinema.org/a/7IM4o1TTTLK2sU99crB3u3RkD

@koutcher koutcher mentioned this issue Feb 1, 2019
Merged
jonas pushed a commit that referenced this issue Mar 22, 2019
@koutcher @jonas
Fix parsing of git rev-parse output (#894)
f0202b3 
Closes #884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ixti @ujjawaldx