Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Plugins tables contains incorrect data in some columns e.g. device name in the MAC address column #951

Closed
3 of 7 tasks
Revum34 opened this issue Jan 11, 2025 · 8 comments
Labels
bug 🐛 Something isn't working next release/in dev image 🚀 This is coming in the next release or was already released if the issue is Closed.

Comments

@Revum34
Copy link

Revum34 commented Jan 11, 2025

Is there an existing issue for this?

The issue occurs in the following browsers. Select at least 2.

  • Firefox
  • Chrome
  • Edge
  • Safari (unsupported) - PRs welcome
  • N/A - This is an issue with the backend

Current Behavior

Going to the Integration menu entry, then Plugins, some tables have an incorrect parsing of data in some columns for the Plugins Objects:

  • Arp-Scan, NMAP, AVAHISCAN and FREEBOX plugins: the Plugin objects table shows device name instead of MAC in Mac column.
  • NMAP plugins contains (unknown) in Name column.

Capture d’écran 2025-01-11 162507
Capture d’écran 2025-01-11 162246
Capture d’écran 2025-01-11 162220

Expected Behavior

MAC column should contain MAC addresses
Name should be filled in Name column instead of (unknown).

Steps To Reproduce

Just go to Integrations menu, Plugins entry and display the data

app.conf

No response

docker-compose.yml

services:
  netalertx2:
    container_name: NetAlertX2
    healthcheck:
      test: curl -f http://localhost:17812/ || exit 1
    mem_limit: 4g
    cpu_shares: 768
    security_opt:
      - no-new-privileges:true
    volumes:
      - /volume1/docker/netalertx2/config:/app/config:rw
      - /volume1/docker/netalertx2/db:/app/db:rw
      - /volume1/docker/netalertx2/logs:/app/front/log:rw
      - type: tmpfs
        target: /app/api
    environment:
      TZ: Europe/Paris
      PORT: 17812
      PUID: 1026
      PGID: 100
    network_mode: host
    restart: on-failure:5
    image: jokobsk/netalertx:latest

What branch are you running?

Production

app.log

Issue doesn't create an entry in the log with Trace logging.

Debug enabled

  • I have read and followed the steps in the wiki link above and provided the required debug logs and the log section covers the time when the issue occurs.
@Revum34 Revum34 added the bug 🐛 Something isn't working label Jan 11, 2025
@jokob-sk
Copy link
Owner

Hi @Revum34 ,

Next version will have the MAC and name displayed like this with an updated header:

image

@jokob-sk jokob-sk added the next release/in dev image 🚀 This is coming in the next release or was already released if the issue is Closed. label Jan 12, 2025
@jokob-sk
Copy link
Owner

The (unknown) value in the nmap plugin is by design. If a host name is discovered by the plugin, it's added via that column. Otherwise the already discovered name from other plugins is used. I changed the title to Resolved Name to make it a bit clearer. I also clarified the docs / README of the plugin:

This plugin is not the best for name resolution (Use e.g.: NSLOOKUP, AVAHISCAN instead), however if available a name will be displayed in the Resolved Name column.

jokob-sk pushed a commit that referenced this issue Jan 12, 2025
@jokob-sk
Copy link
Owner

It would be great if you could test this. Can you please switch to the netalertx-dev docker image (backup everything at first or, ideally spin up a separate container with a separate db and config), in about 15 minutes (or after the last action finishes) from now?

Make sure you refresh your browser cache - and click the 🔄 refresh button in the top right corner.

Thanks in advance,
j

@Revum34
Copy link
Author

Revum34 commented Jan 12, 2025

Hi @jokob-sk
Thanks for your fast answer and for the fix.
I confirm that the issue has been fixed in netalertx-dev image.

But you changed the MAC column to MAC(Name).
While the Plugin Objects list shows the MAC address along with the Name, the Event History list shows only the MAC Address.
N.B.: I could check this only with the Arp-Scan Plugin that contains data in Events History.

Capture d’écran 2025-01-12 153501
Capture d’écran 2025-01-12 153150

jokob-sk pushed a commit that referenced this issue Jan 12, 2025
@jokob-sk
Copy link
Owner

Hi,

This should be in 15 min in the dev image.

ezgif-4-4ef49f44e5

@Revum34
Copy link
Author

Revum34 commented Jan 13, 2025

Hi @jokob-sk ,
I test the new dev image and all it correct now.
Thanks

@jokob-sk
Copy link
Owner

Hi @Revum34 ,

Thanks for testing!

@jokob-sk
Copy link
Owner

releasing in 15 min -> closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working next release/in dev image 🚀 This is coming in the next release or was already released if the issue is Closed.
Projects
None yet
Development

No branches or pull requests

2 participants