migrate to .NET 4.6.2 #86
Conversation
src/D2DWinForm/D2DWinForm.csproj
Outdated
| <TargetFrameworks>net4.0;netcoreapp3.1</TargetFrameworks> | ||
| <TargetFrameworks>net6.0-windows</TargetFrameworks> |
There was a problem hiding this comment.
This would mean users of .NET Framework could no longer use this library.
I was recently trying to get this library working in a small personal VS extension I was writing (which is why I needed strong naming). VS runs on net472, so this change would mean I could no longer use updated versions of the library in VS.
If there's no need to use features from the newer runtime or framework then upgrading this here seems like creating a limitation that's not needed for consumers of the project.
src/Examples/Examples.csproj
Outdated
| @@ -1,25 +1,25 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk.WindowsDesktop"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFrameworks>net4.7.2;netcoreapp3.1</TargetFrameworks> | |||
| <TargetFrameworks>net6.0-windows</TargetFrameworks> | |||
There was a problem hiding this comment.
Adding net6.0-windows to the example project makes sense, as it validates that the library can in fact work in .NET 6. However I would keep net4.7.2 and netcoreapp3.1 as well, just for coverage.
src/D2DLibExport/D2DLibExport.csproj
Outdated
| <TargetFrameworks>net4.0;netstandard2.1</TargetFrameworks> | ||
| <TargetFrameworks>net6.0;netstandard2.0</TargetFrameworks> |
There was a problem hiding this comment.
If lowering to netstandard2.0 is possible, we should do that in order to maximise the number of environments that can consume this library. Keeping net4.0 would also maximise that.
|
@drewnoakes Thanks for your review! The settings have been fixed. Could you please check again? Just one point that I'm not sure is upgrading .NET 4.0 to .NET 4.6.2 because .NET 4.0 seems no longer supported and cannot be compiled with VS2022. |
|
Increasing the requirement to 4.6 is fine and shouldn't leave too many people behind. They can always use the old package if needed. |
Change to .NET 6.0Change .NET 4.0 to .NET 4.6.2 (since .NET 4.0 seems no longer supported)