Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change simple cookie header parse to keep most recently set #1835

Closed
wants to merge 1 commit into from
Closed

Change simple cookie header parse to keep most recently set #1835

wants to merge 1 commit into from
+7 −5

Conversation

lvpiao
Copy link

@lvpiao lvpiao commented Sep 7, 2022

No description provided.

@jhy jhy changed the title Fix #1831 Change simple cookie header parse to keep most recently set Jan 5, 2023
@jhy jhy linked an issue Jan 5, 2023 that may be closed by this pull request
Simple cookie parser keeps first cookie with same name, not most recently set #1831
Closed
@jhy
Copy link
Owner

jhy commented Sep 11, 2024

Thanks, and sorry for the late review. I have implemented the fix for #1831 in b6bd4b4. This works correctly if there are multiple cookies with the same name but different paths - just going with the most recently set may not be the correct choice in that case.

@jhy jhy closed this Sep 11, 2024
@anonyein
Copy link

anonyein commented Sep 15, 2024 •
edited
Loading

I recommend that this commit broken response's "set-cookie" list and makes cookies lacks of lots of messages!
b6bd4b4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simple cookie parser keeps first cookie with same name, not most recently set
3 participants
@lvpiao @jhy @anonyein