Aborting transactions in killed threads #752
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jeremy -
So, it turned out that the unfortunate issue where the status of a killed thread was "run" was introduced in Ruby 1.9 but fixed in Ruby 2.0. This means that on Ruby 2.0, 2.1, and recent versions of Rubinius we can use the safer 1.8 behavior of executing a rollback if the current thread's status is "aborting". The specs pass on every version of Ruby on my system:
I couldn't find the list of Rubies you test Sequel on - are there any others I should run?
Thanks!