Feature/j value

[minidfx]

I had some problems with Nustache to identify a boolean with Newtonsoft because it return a JValue instead of a boolean as type.

I added a new micro service to identify the value of the Newtonsoft.Json.Linq.JValue with its tests.

[minidfx]

Currently I have updated the Nuget package on my server as prerelease version but I prefer to use your official Nuget package.

When do you think take a look on this pull requests?

[Romanx]

Hey there,

It seems like it would work perfectly fine however it goes out of the ValueGetter/ValueGetterFactory structure that Nustache uses to find its values.

I'd be hesitant about including it purely as this logic should be within that structure and it could set bad precedent.

I was planning to look at performing essentially the same logic but within a factory (for checking if the object is a JToken and in a ValueGetter which performs the logic of getting the typed values from the object.

This was IsTruthy wouldn't have to be adjusted as it would be performed on primitive types.

What do you think of that solution?

[minidfx]

Ok, I will apply the logic into a new one ValueGetter with its factory.

[Romanx]

Perfect thank you, if you need any advice feel free to ask. I would do it myself but i'm currently working on a side project and have little time.

[minidfx]

Done, I saw that you already have PropertyDescriptorValueGetterFactory and I just added a condition into PropertyDescriptorValueGetter to check whether the value received is a JValue.

The previous unit tests still works very well.

[minidfx]

Hello,

When do you think check the PR and update the Nuget package? Because I need an update soon and I whether it's too late, I will create a new one just for me.

[Romanx]

I should be able to merge this and get it pushed today. Within the next few hours, work permitting at latest this evening GMT.

[minidfx]

Thank you! Sorry to rush you ;)

[Romanx]

This has been merged in for you and released. Thanks for your contribution.

[minidfx]

Thank you for your quick answer.