Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(popover): rtl #2121

Merged
merged 8 commits into from
Mar 29, 2024
Merged

feat(popover): rtl #2121

merged 8 commits into from
Mar 29, 2024

Conversation

xiaoyatong
Copy link
Collaborator

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • fork仓库代码是否为最新避免文件冲突
  • Files changed 没有 package.json lock 等无关文件

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.20%. Comparing base (1e86de9) to head (302557c).

❗ Current head 302557c differs from pull request most recent head 4423c5c. Consider uploading reports for the commit 4423c5c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2121   +/-   ##
=======================================
  Coverage   86.20%   86.20%           
=======================================
  Files         215      215           
  Lines       22786    22788    +2     
  Branches     2493     2495    +2     
=======================================
+ Hits        19643    19645    +2     
  Misses       3138     3138           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xiaoyatong added 2 commits March 22, 2024 21:11
@xiaoyatong xiaoyatong requested a review from eiinu March 25, 2024 06:39
@eiinu
Copy link
Member

eiinu commented Mar 25, 2024

image
开启 RTL 后,Popover H5 demo 错位

@oasis-cloud
Copy link
Collaborator

image image

@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 27, 2024
xiaoyatong and others added 4 commits March 28, 2024 15:21

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@oasis-cloud oasis-cloud merged commit 32f8303 into jdf2e:next Mar 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants