-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move to use junit+allure over karate #1968
base: main
Are you sure you want to change the base?
Conversation
I love Karate and I'll always be a fan of it but as time passed I realized it is a big dependency to have with all the javascript/nashorn compabilitie for something that for us is just calling out to a shell and does string comparisons. This starts removing need for using Karate and instead uses plain JUnit as gradle integration tests + using Allure to collect intermediate step results. That last part was/is a key feature of karate where we can see all the steps before and after a reported failure. To run the build and see report try out `just itestreport`
this is related to #1967 but it is not required we move everything to assertj - can do it iteratively. |
goal of this would eventually remove need for the various workarounds/managing of karate tests. |
added fix to ensure actual built jbang is on path so it will succeed in github action |
That would be nice, because running the karate tests always messes up my system somewhat. Hopefully when running from JUnit we can set up a proper test environment. |
Hmm - karate was supposed to run isolated - done the same setup now at least :) |
For me it always created a couple of files and modified one. I almost committed those changes by mistake a number of times. |
ah yes - true; there is some of that - being inside proper java code should make it much easier to track down. |
I love Karate and I'll always be a fan of it but
as time passed I realized it is a big dependency to have
with all the javascript/nashorn compabilitie for something
that for us is just calling out to a shell and does string comparisons.
This starts removing need for using Karate and instead uses plain
JUnit with assertj as gradle integration tests + using Allure to collect intermediate step results.
That last part was/is a key feature of karate where we can see all the steps
before and after a reported failure.
To run the build and see report try out
just itestreport
end result is to remove karate/itests possibly even the asserta ones (they only run on non-windows anyways) and have it all handled in gradle run and standard junit execution and reporting.