Improve QA workflow #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szepeviktor
commented
Oct 16, 2024
| @@ -5,7 +5,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| php: [ '8.1', '8.2', '8.3' ] | |||
| lowest: [ '0','1' ] | |||
| dependencies: [ highest, lowest ] | |||
There was a problem hiding this comment.
Display meaningful words in workflow run titles, no more binary code.
szepeviktor
commented
Oct 16, 2024
| @@ -16,21 +16,20 @@ jobs: | |||
| php-version: ${{ matrix.php }} | |||
| extensions: mbstring, intl | |||
| coverage: xdebug | |||
| tools: composer:v2 | |||
There was a problem hiding this comment.
Composer v2 is the default for years.
szepeviktor
commented
Oct 16, 2024
| env: | ||
| COMPOSER_PREFER_LOWEST: ${{ matrix.lowest }} | ||
| PHING_VERSION: '3.0.0' |
szepeviktor
commented
Oct 16, 2024
| COMPOSER_PREFER_LOWEST: ${{ matrix.lowest }} | ||
| PHING_VERSION: '3.0.0' | ||
| run: | | ||
| mkdir -p ~/.local/bin |
There was a problem hiding this comment.
This is already on PATH.
actions/runner-images#2491
szepeviktor
commented
Oct 16, 2024
Comment on lines
-32
to
-33
| - name: Composer install | ||
| run: bin/phing composer:install |
There was a problem hiding this comment.
phing composer:install did nothing at all
|
Hi, I will accept your PR and make some changes later. |
|
Glad to contribute. |
|
@jawira This is your go-to solution.
|
|
@szepeviktor I followed your suggestions and improved pipelines even more. Thanks! :) |
|
You're welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see comments below.