(fix): jest shouldn't transform json files in node_modules #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- not sure why ts-jest was picking these up and giving warnings, but TSDX's custom transformIgnorePatterns is different from jest's default (everything in node_modules), so set it to ignore json too
swyxio
approved these changes
Feb 5, 2020
|
#513 fixes the root cause of this, so closing as unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSDX's custom transformIgnorePatterns is different from jest's
default (everything in node_modules), so set it to ignore json too
Fixes #161
@jaredpalmer is there a reason TSDX has a custom
transformIgnorePattern? It's been like that since one of the first commits so idk.Jest's default is just
/node_modules/, so not sure why TSDX's is slightly different. To allow for transforming TS files innode_modules?