Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The *Create new Team* function (admin role) in team selection dialog is broken #126

Closed
3 tasks done
rseedorff opened this issue Jun 21, 2022 · 0 comments
Closed
3 tasks done

The *Create new Team* function (admin role) in team selection dialog is broken #126

rseedorff opened this issue Jun 21, 2022 · 0 comments
Labels
bug Something isn't working frontend
Milestone
v2.0.1

Comments

@rseedorff
Copy link
Contributor

rseedorff commented Jun 21, 2022 •
edited by Amar-Bolkan
Loading

As a user with the role ROLE_ADMIN im allowed to use the create new team button in the select team modal dialog.

Problem

Due to the last model change there are some fields missing in the create new team modal dialog:

  • parent (required)
  • expiration

Due to the missing required fields the save action does not work properly.

Acceptance Criteria

  • Add missing fields in the dialog create new team (example 1)
  • Add missing field in the team edit dialog (example 2)
  • Ensure the save action is doing its job (example 1 and example 2)

Examples

Example 1: Create new Team Modal Dialog with missing fields:

image

Example 2: Update Team Dialog with missing fields:

image

Example 3: Create new Team Entity:

image
@rseedorff rseedorff added bug Something isn't working frontend labels Jun 21, 2022
@rseedorff rseedorff changed the title Create new Team function (admin role) in team selection dialog is broken The *Create new Team* function (admin role) in team selection dialog is broken Jun 21, 2022
@Amar-Bolkan Amar-Bolkan self-assigned this Jul 7, 2022
Amar-Bolkan added a commit that referenced this issue Jul 7, 2022
@Amar-Bolkan
Issue #126: Add teamGroups and expirationDate field to team edit form

Verified

This commit was signed with the committer’s verified signature.
Amar-Bolkan
GPG key ID: A89AB8EA9557F1FB
Verified
Learn about vigilant mode
93bc6d5
Amar-Bolkan added a commit that referenced this issue Jul 7, 2022
@Amar-Bolkan
Issue #126: Add label to expiration date input field

Verified

This commit was signed with the committer’s verified signature.
Amar-Bolkan
GPG key ID: A89AB8EA9557F1FB
Verified
Learn about vigilant mode
88ccd1a
Amar-Bolkan added a commit that referenced this issue Jul 11, 2022
@Amar-Bolkan
Issue #126: Display current teamgroup title, when editing team

Verified

This commit was signed with the committer’s verified signature.
Amar-Bolkan
GPG key ID: A89AB8EA9557F1FB
Verified
Learn about vigilant mode
ccb5003 
To display a preselected option the ngModel property compares
primitive values. Binding ngModel to a variable of non
primitive data type leads to the compairson failing,
which in turn results in no preselected option being displayed.
This can be fixed by using the compareWith property to
introduce a custom comparator function.
@rseedorff rseedorff added this to the v2.0.1 milestone Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working frontend
Projects
None yet
Milestone
v2.0.1
Development

No branches or pull requests
2 participants
@rseedorff @Amar-Bolkan