Web Unexpected null value #967
Labels
problem
An unconfirmed bug.
Comments
|
same bug |
|
I found the error! It's the new enhancement from v. 2.2.0 |
|
I will fix this until tomorrow. It seems like it's not a good idea to merge things with a failing pipeline. |
|
I'm having the exact same issue. Here's the counter sample app (after I made changes to make it compatible with latest flutter version) import 'dart:async';
import 'dart:collection';
import 'dart:math';
import 'dart:typed_data';
import 'package:hive/hive.dart';
import 'package:hive/src/adapters/big_int_adapter.dart';
import 'package:hive/src/adapters/date_time_adapter.dart';
import 'package:hive/src/backend/storage_backend_memory.dart';
import 'package:hive/src/box/box_base_impl.dart';
import 'package:hive/src/box/box_impl.dart';
import 'package:hive/src/box/default_compaction_strategy.dart';
import 'package:hive/src/box/default_key_comparator.dart';
import 'package:hive/src/box/lazy_box_impl.dart';
import 'package:hive/src/registry/type_registry_impl.dart';
import 'package:hive/src/util/extensions.dart';
import 'package:meta/meta.dart';
import 'backend/storage_backend.dart';
/// Not part of public API
class HiveImpl extends TypeRegistryImpl implements HiveInterface {
final _boxes = HashMap<String, BoxBaseImpl>();
final _openingBoxes = HashMap<String, Future>();
BackendManagerInterface? _manager;
final Random _secureRandom = Random.secure();
/// Not part of public API
@visibleForTesting
String? homePath;
/// Not part of public API
HiveImpl();
/// Not part of public API
@visibleForTesting
HiveImpl.debug(this._manager) {
_registerDefaultAdapters();
}
/// Not part of public API
@visibleForTesting
HiveImpl.test() : _manager = BackendManager.select() {
registerAdapter(DateTimeAdapter<DateTime>(), internal: true);
registerAdapter(BigIntAdapter(), internal: true);
}
void _registerDefaultAdapters() {
registerAdapter(DateTimeWithTimezoneAdapter(), internal: true);
registerAdapter(DateTimeAdapter<DateTimeWithoutTZ>(), internal: true);
registerAdapter(BigIntAdapter(), internal: true);
}
@override
void init(
String? path, {
HiveStorageBackendPreference backendPreference =
HiveStorageBackendPreference.native,
}) {
homePath = path;
_manager ??= BackendManager.select(backendPreference);
_registerDefaultAdapters();
}
Future<BoxBase<E>> _openBox<E>(
String name,
bool lazy,
HiveCipher? cipher,
KeyComparator comparator,
CompactionStrategy compaction,
bool recovery,
String? path,
Uint8List? bytes,
String? collection,
) async {
assert(path == null || bytes == null);
assert(name.length <= 255 && name.isAscii,
'Box names need to be ASCII Strings with a max length of 255.');
name = name.toLowerCase();
if (isBoxOpen(name)) {
if (lazy) {
return lazyBox(name);
} else {
return box(name);
}
} else {
if (_openingBoxes.containsKey(name)) {
await _openingBoxes[name];
if (lazy) {
return lazyBox(name);
} else {
return box(name);
}
}
var completer = Completer();
_openingBoxes[name] = completer.future;
BoxBaseImpl<E>? newBox;
try {
StorageBackend backend;
if (bytes != null) {
backend = StorageBackendMemory(bytes, cipher);
} else {
backend = await _manager!
.open(name, path ?? homePath, recovery, cipher, collection);
}
if (lazy) {
newBox = LazyBoxImpl<E>(this, name, comparator, compaction, backend);
} else {
newBox = BoxImpl<E>(this, name, comparator, compaction, backend);
}
await newBox.initialize();
_boxes[name] = newBox;
completer.complete();
return newBox;
} catch (error, stackTrace) {
newBox?.close();
completer.completeError(error, stackTrace);
rethrow;
} finally {
// ignore: unawaited_futures
_openingBoxes.remove(name);
}
}
}
@override
Future<Box<E>> openBox<E>(
String name, {
HiveCipher? encryptionCipher,
KeyComparator keyComparator = defaultKeyComparator,
CompactionStrategy compactionStrategy = defaultCompactionStrategy,
bool crashRecovery = true,
String? path,
Uint8List? bytes,
String? collection,
@Deprecated('Use encryptionCipher instead') List<int>? encryptionKey,
}) async {
if (encryptionKey != null) {
encryptionCipher = HiveAesCipher(encryptionKey);
}
return await _openBox<E>(name, false, encryptionCipher, keyComparator,
compactionStrategy, crashRecovery, path, bytes, collection) as Box<E>;
}
@override
Future<LazyBox<E>> openLazyBox<E>(
String name, {
HiveCipher? encryptionCipher,
KeyComparator keyComparator = defaultKeyComparator,
CompactionStrategy compactionStrategy = defaultCompactionStrategy,
bool crashRecovery = true,
String? path,
String? collection,
@Deprecated('Use encryptionCipher instead') List<int>? encryptionKey,
}) async {
if (encryptionKey != null) {
encryptionCipher = HiveAesCipher(encryptionKey);
}
return await _openBox<E>(
name,
true,
encryptionCipher,
keyComparator,
compactionStrategy,
crashRecovery,
path,
null,
collection) as LazyBox<E>;
}
BoxBase<E> _getBoxInternal<E>(String name, [bool? lazy]) {
var lowerCaseName = name.toLowerCase();
var box = _boxes[lowerCaseName];
if (box != null) {
if ((lazy == null || box.lazy == lazy) && box.valueType == E) {
return box as BoxBase<E>;
} else {
var typeName = box is LazyBox
? 'LazyBox<${box.valueType}>'
: 'Box<${box.valueType}>';
throw HiveError('The box "$lowerCaseName" is already open '
'and of type $typeName.');
}
} else {
throw HiveError('Box not found. Did you forget to call Hive.openBox()?');
}
}
/// Not part of public API
BoxBase? getBoxWithoutCheckInternal(String name) {
var lowerCaseName = name.toLowerCase();
return _boxes[lowerCaseName];
}
@override
Box<E> box<E>(String name) => _getBoxInternal<E>(name, false) as Box<E>;
@override
LazyBox<E> lazyBox<E>(String name) =>
_getBoxInternal<E>(name, true) as LazyBox<E>;
@override
bool isBoxOpen(String name) {
return _boxes.containsKey(name.toLowerCase());
}
@override
Future<void> close() {
var closeFutures = _boxes.values.map((box) {
return box.close();
});
return Future.wait(closeFutures);
}
/// Not part of public API
void unregisterBox(String name) {
name = name.toLowerCase();
_openingBoxes.remove(name);
_boxes.remove(name);
}
@override
Future<void> deleteBoxFromDisk(String name,
{String? path, String? collection}) async {
var lowerCaseName = name.toLowerCase();
var box = _boxes[lowerCaseName];
if (box != null) {
await box.deleteFromDisk();
} else {
await _manager!.deleteBox(lowerCaseName, path ?? homePath, collection);
}
}
@override
Future<void> deleteFromDisk() {
var deleteFutures = _boxes.values.toList().map((box) {
return box.deleteFromDisk();
});
return Future.wait(deleteFutures);
}
@override
List<int> generateSecureKey() {
return _secureRandom.nextBytes(32);
}
@override
Future<bool> boxExists(String name,
{String? path, String? collection}) async {
var lowerCaseName = name.toLowerCase();
return await _manager!
.boxExists(lowerCaseName, path ?? homePath, collection);
}
}The app running on Chrome, macOS outputs this stack trace: It works fine on Chrome on Windows, but on my mac it breaks. [EDIT] I'm using Flutter 3.0.0, Hive v2.2.0 |
|
I think this can be resolved by calling |
|
@TheOneWithTheBraid I used For now, i think safe way is downgrade to version |
TheOneWithTheBraid
pushed a commit
that referenced
this issue
May 18, 2022
- remove need for manual `Hive.init()` call - provide default backend manager - fix most tests Fixes: #967 Signed-off-by: TheOneWithTheBraid <[email protected]>
|
Ah, I see the problem you face: For some reasons, the As of now, you can override is by git: dependency_overrides:
hive:
git:
url: https://github.com/hivedb/hive.git
path: hive
ref: braid/backend-manager-fallback
hive_flutter:
git:
url: https://github.com/hivedb/hive.git
path: hive_flutter
ref: braid/backend-manager-fallback |
TheOneWithTheBraid
pushed a commit
to TheOneWithTheBraid/hive
that referenced
this issue
May 18, 2022
- remove need for manual `Hive.init()` call - provide default backend manager - fix most tests Fixes: isar#967 Signed-off-by: TheOneWithTheBraid <[email protected]>
|
2.2.0 needs to be pulled. It's a disaster. |
roubachof
pushed a commit
to roubachof/hive
that referenced
this issue
May 24, 2022
- remove need for manual `Hive.init()` call - provide default backend manager - fix most tests Fixes: isar#967 Signed-off-by: TheOneWithTheBraid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
_hiveBox = await Hive.openBox(_boxName)In web when trying to open box, getting Unexpected null value exception.
Occurring on the latest version 2.2.0, could not find this issue in 2.1.0
The text was updated successfully, but these errors were encountered: