Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][UR] Log sycl-ls error messages related to adapter loading #17490

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

bratpiorka
Copy link
Contributor

Changes:

  • change the log level to "error" for all errors related to adapter dependencies during UR adapter loading
  • enable the printing of UR adapter errors in sycl-ls from platform::get_platforms() using environment variables

With this PR, there will be no changes for the user in the default scenario where some adapters exist and some are missing (a missing adapter is not considered an error). In cases where a dependency is missing, the following example message will be displayed:

<LOADER>[ERROR]: failed to load adapter 'libur_adapter_level_zero.so.0' with error: libumf.so.0: cannot open shared object file: No such file or directory

Here is the message for missing symbols (a case where a dependency is not compatible with the rest of the libraries):

<LOADER>[ERROR]: failed to load adapter 'libur_adapter_level_zero.so.0' with error: /home/rrudnick/llvm/build/lib/libumf.so.0: version `UMF_0.10' not found (required by /home/rrudnick/llvm/build/lib/libur_adapter_level_zero.so.0)

@bratpiorka bratpiorka requested a review from pbalcer March 17, 2025 16:47
@bratpiorka bratpiorka force-pushed the review/rrudnick/sycl_ls_err branch from 89a3054 to 457a1ce Compare March 18, 2025 14:26
@bratpiorka bratpiorka force-pushed the review/rrudnick/sycl_ls_err branch from 457a1ce to 3343425 Compare March 18, 2025 15:12
@bratpiorka bratpiorka marked this pull request as ready for review March 19, 2025 09:52
@bratpiorka bratpiorka requested review from a team as code owners March 19, 2025 09:52
@bratpiorka bratpiorka force-pushed the review/rrudnick/sycl_ls_err branch from 3343425 to c118a99 Compare March 19, 2025 15:40
@aelovikov-intel
Copy link
Contributor

log sycl-ls error adapter loading messages

First, needs [SYCL][UR] tags prefix.
Second, should start with upper-case ("Log ...")
Third, doesn't seem to be a proper sentence, can you re-phrase please?

@bratpiorka
Copy link
Contributor Author

First, needs [SYCL][UR] tags prefix.
Second, should start with upper-case ("Log ...")
Third, doesn't seem to be a proper sentence, can you re-phrase please?

thank you for noticing this, done

@aelovikov-intel
Copy link
Contributor

First, needs [SYCL][UR] tags prefix.
Second, should start with upper-case ("Log ...")
Third, doesn't seem to be a proper sentence, can you re-phrase please?

thank you for noticing this, done

I think all of them apply still...

@bratpiorka bratpiorka changed the title log sycl-ls error adapter loading messages [SYCL][UR] Log SYCL-LS error messages related to adapter loading Mar 20, 2025
@bratpiorka bratpiorka changed the title [SYCL][UR] Log SYCL-LS error messages related to adapter loading [SYCL][UR] Log sycl-ls error messages related to adapter loading Mar 20, 2025
@bratpiorka
Copy link
Contributor Author

@intel/llvm-gatekeepers please merge

@martygrant martygrant merged commit 39b3025 into intel:sycl Mar 21, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants