Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UR][L0] Release parent of sub-buffer when sub-buffer dies #17489

Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from
Open

[UR][L0] Release parent of sub-buffer when sub-buffer dies #17489

wants to merge 1 commit into from

Conversation

steffenlarsen
Copy link
Contributor

This commit fixes an issue where the sub-buffer object in the L0 V1 adapter would not release its retained parent, causing leaks.

@steffenlarsen steffenlarsen requested a review from a team as a code owner March 17, 2025 16:44
@steffenlarsen steffenlarsen marked this pull request as draft March 17, 2025 16:45
nrspruit
nrspruit approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@nrspruit nrspruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I think you may be missing a rebase based on the patch due to the windows code gen failure.,

@steffenlarsen
Copy link
Contributor Author

This looks good to me. I think you may be missing a rebase based on the patch due to the windows code gen failure.,

That's odd. It should be based off tip.

@nrspruit
Copy link
Contributor

Associated change in earlier UR 0.11.x branch: oneapi-src/unified-runtime#2734

@nrspruit nrspruit marked this pull request as ready for review March 17, 2025 19:31
@nrspruit
Copy link
Contributor

The windows error seems unrelated, if this has already been rebased it may be a CI issue.

@steffenlarsen @nrspruit
[UR][L0] Release parent of sub-buffer when sub-buffer dies
1a4c29f 
This commit fixes an issue where the sub-buffer object in the L0 V1
adapter would not release its retained parent, causing leaks.

Signed-off-by: Larsen, Steffen <[email protected]>
@nrspruit nrspruit force-pushed the steffen/release_parent_l0 branch from d532e64 to 1a4c29f Compare March 19, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrspruit nrspruit nrspruit approved these changes

@pbalcer pbalcer pbalcer approved these changes

@igchor igchor igchor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@steffenlarsen @nrspruit @pbalcer @igchor