-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DevTSAN][E2E] Run test with deflake script to make positive tests more robust #17483
Conversation
…re robust Also disable two unexpected flaky negative tests for further investigation
@intel/dpcpp-devops-reviewers, @intel/llvm-reviewers-runtime, could you please help review this PR? Thanks. |
https://llvm.org/docs/CommandGuide/lit.html#test-status-results:
Can you please check if that would work for you? Unfortunately, this feature doesn't have any other documentation (at least I was unable to find out), so you'd need to do some work here. |
Hi @aelovikov-intel, thanks for your information. I tried 'FLAKYPASS' locally, it works here. But there is problem that 'FLAKYPASS' will retry whole testcase (including build and run) when meet fail, it will waste a lot of unnecessary time (we only need to retry run). So I think current solution to use deflake script is more suitable for sycl/test-e2e. |
In pre-commit CI we run build/run of e2e tests separately... Also, can you look into implementing something like these retries for "run"-only RUN lines in e2e's |
@aelovikov-intel, updated the PR to use "ALLOW_RETRIES".
The retry's work is controlled by lit.TestRunner.py https://github.com/intel/llvm/blob/sycl/llvm/utils/lit/lit/TestRunner.py#L2268. It's test level instead of command level. So if we want to implement it in format.py, the most obvious way is to substitute '%{run}' with something like deflake script do when ALLOW_RETRIES is specified. Not sure if this is what you are expecting. |
I was too late to spot that title needed an update... :( |
Sorry, I also forgot to update it... |
Also disable two unexpected flaky negative tests for further investigation