[SYCL][NewOffload][NFC] Add SYCLPostLink library component. #17454
Conversation
This change adds a component that should contain all post-link processing (e.g., ESIMD,
specialization constants). It is not appropriate to put all this functionality
into SYCLLowerIR because there is a dependency in LLVMPasses on SYCLLowerIR.
Post-link processing requires capabilities such as linking and pipeline
building, which being added to SYCLLowerIR will create a dependancy
cycle.
After this change, the dependency diagram will look like the following:
SYCLLowerIR -> Passes -> clang
-------> opt
|
V
SYCLPostLink -> clang-linker-wrapper
|-------------> sycl-post-link
--------------> sycl-jit.
maksimsab
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
maksimsab
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
| @@ -0,0 +1,27 @@ | |||
| add_llvm_component_library(LLVMSYCLPostLink | |||
There was a problem hiding this comment.
about the name, to me syclpostlink is a tool, so i would expect files to be in clang/tools, so maybe we could rename it to something else, but i don't have any great ideas, SYCLLowering, SYCLFinalization, idk
There was a problem hiding this comment.
sycl-post-link's help text reads:
This is a collection of utilities run on device code's LLVM IR before handing off to back-end for further compilation or emitting SPIRV.
... so I think the verb "finalize" would capture that well. SYCLFinalizeIR in analogy to SYCLLowerIR maybe?
I also wouldn't mind keeping the "post-link" moniker. SYCLPostLinkUtils or so would make it clear that this is not a tool.
There was a problem hiding this comment.
sycl-post-link tool is going to disappear after migration to New Offload Model.
clang/tools is not appropriate since sycl-jit and intel's fortran compiler depend on this functionality.
|
@intel/llvm-gatekeepers Can we merge it? |
|
|
@aelovikov-intel Please, specify your concern. If it was a failing ProtexIP, then I didn't find in it's output any clues that it is related to my change. |
First, you have to let gatekeepers know why you think failures could be ignored. Second, your testing was still in progress when you pinged us (win e2e). |
This change adds a component that should contain all post-link processing (e.g., ESIMD, specialization constants). It is not appropriate to put all this functionality into SYCLLowerIR because there is a dependency in LLVMPasses on SYCLLowerIR. Post-link processing requires capabilities such as linking and pipeline building, which being added to SYCLLowerIR will create a dependancy cycle.
After this change, the dependency diagram will look like the following: