[SYCL] Change SPIR-V Enum token type from unsigned int to int for barrier builtins #17438

wenju-he · 2025-03-13T05:34:15Z

Motivation is unifying SPIR-V builtin mangling to enhance SYCL AOT support for backend targets that bypass SPIR-V generation. Changing to signed int type aligns with

SPV-IR output of llvm-spirv translator.
Default underlying type of enum being int, e.g. enum defined in tablegened LLVM SPIR-V backend header and standard SPIR-V header.

Changes are mainly made to following places:

clang/lib/Sema/SPIRVBuiltins.td
libclc/libspirv

…rier builtins Motivation is unifying SPIR-V builtin mangling to enhance SYCL AOT support for backend targets that bypass SPIR-V generation. Changing to signed int type aligns with * SPV-IR output of llvm-spirv translator. * Default underlying type of enum being int, e.g. enum defined in tablegened LLVM SPIR-V backend header and standard SPIR-V header. Changes are mainly made to following places: * sycl/include/sycl/__spirv/spirv_ops.hpp * clang/lib/Sema/SPIRVBuiltins.td * libclc/libspirv

sommerlukas

SYCL-JIT changes LGTM.

…ups builtins Same motivatoin as in PR intel#17438

…ups builtins Motivation is the same as PR intel#17438, i.e. unifying SPIR-V builtin mangling to enhance SYCL AOT support for backend targets that bypass SPIR-V generation.

npmiller

ptx/gcn changes LGTM

Naghasan · 2025-03-13T10:13:49Z

sycl/source/spirv_ops.cpp

-__SYCL_EXPORT void __spirv_ControlBarrier(__spv::Scope Execution,
-                                          __spv::Scope Memory,
-                                          uint32_t Semantics) noexcept {
+__SYCL_EXPORT void __spirv_ControlBarrier(int32_t Execution, int32_t Memory,


These are for the old host device support, I'd advise to not touch these as it creates an ABI break and that's only for the host.

thanks @Naghasan, reverted the ABI change

…PIRVBuiltins.td Also change scope and memory semantics type from Enum from int, similar as PR intel#17438 volatile is removed from pointer parameter type, to align with SVP-IR and clang/lib/Sema/SPIRVBuiltins.td.

…PIRVBuiltins.td Change scope and memory semantics type from Enum from int, similar as in PR intel#17438. volatile is removed from function parameter pointer type, to align with SVP-IR and clang/lib/Sema/SPIRVBuiltins.td.

uditagarwal97

Changes in sycl/test/check_device_code/ LGTM.

AllanZyne

Looks good on "sanitizer_defs.hpp"

libdevice/nativecpu_utils.cpp

wenju-he · 2025-03-18T04:49:30Z

kindly ping @intel/dpcpp-tools-reviewers, @intel/dpcpp-cfe-reviewers for review

Fznamznon · 2025-03-18T09:50:00Z

clang/lib/Sema/SPIRVBuiltins.td

-  // TODO: Allow enum flags instead of UInt ?
-  // TODO: We should enforce that the UInt must be a literal.
-  def : SPVBuiltin<name, [Void, UInt, UInt, UInt], Attr.Convergent>;
+  // TODO: Allow enum flags instead of Int ?


Should this also have a clang test?

updated clang test in 49d9641

frasercrmck

libclc LGTM

maksimsab

SYCLLowerIR LGTM.

wenju-he · 2025-03-19T00:11:34Z

@intel/llvm-gatekeepers please merge, thanks

wenju-he requested review from a team as code owners March 13, 2025 05:34

wenju-he requested review from uditagarwal97 and jchlanda March 13, 2025 05:34

wenju-he temporarily deployed to WindowsCILock March 13, 2025 05:34 — with GitHub Actions Inactive

wenju-he requested a review from Naghasan March 13, 2025 05:40

wenju-he temporarily deployed to WindowsCILock March 13, 2025 06:27 — with GitHub Actions Inactive

sommerlukas approved these changes Mar 13, 2025

View reviewed changes

wenju-he added a commit to wenju-he/llvm that referenced this pull request Mar 13, 2025

[SYCL] Change SPIR-V Enum token type from unsigned int to int for gro…

6af50a8

…ups builtins Same motivatoin as in PR intel#17438

wenju-he mentioned this pull request Mar 13, 2025

[SYCL] Change SPIR-V Enum token type from unsigned int to int for groups builtins #17445

Open

npmiller approved these changes Mar 13, 2025

View reviewed changes

Naghasan reviewed Mar 13, 2025

View reviewed changes

wenju-he added 2 commits March 13, 2025 17:34

revert host code ABI change

e025be4

Merge branch 'sycl' into barrier-spirv-token-unsigned-to-signed

400d30c

wenju-he temporarily deployed to WindowsCILock March 14, 2025 00:38 — with GitHub Actions Inactive

wenju-he requested a review from Naghasan March 14, 2025 00:39

wenju-he temporarily deployed to WindowsCILock March 14, 2025 01:03 — with GitHub Actions Inactive

wenju-he mentioned this pull request Mar 14, 2025

[SYCL] Move SPIR-V atomic builtins declarations into clang/lib/Sema/SPIRVBuiltins.td #17471

Open

Naghasan approved these changes Mar 14, 2025

View reviewed changes

uditagarwal97 approved these changes Mar 14, 2025

View reviewed changes

AllanZyne approved these changes Mar 17, 2025

View reviewed changes

hvdijk reviewed Mar 17, 2025

View reviewed changes

libdevice/nativecpu_utils.cpp Outdated Show resolved Hide resolved

change type to int32_t for __mux_work_group_barrier/__mux_mem_barrier

2b5b55d

wenju-he temporarily deployed to WindowsCILock March 18, 2025 04:46 — with GitHub Actions Inactive

wenju-he requested a review from hvdijk March 18, 2025 04:47

wenju-he temporarily deployed to WindowsCILock March 18, 2025 05:33 — with GitHub Actions Inactive

Fznamznon reviewed Mar 18, 2025

View reviewed changes

hvdijk approved these changes Mar 18, 2025

View reviewed changes

frasercrmck approved these changes Mar 18, 2025

View reviewed changes

add clang test

49d9641

wenju-he temporarily deployed to WindowsCILock March 18, 2025 12:49 — with GitHub Actions Inactive

wenju-he requested a review from Fznamznon March 18, 2025 12:50

maksimsab approved these changes Mar 18, 2025

View reviewed changes

wenju-he temporarily deployed to WindowsCILock March 18, 2025 13:43 — with GitHub Actions Inactive

Fznamznon approved these changes Mar 18, 2025

View reviewed changes

uditagarwal97 merged commit 7f2971a into intel:sycl Mar 19, 2025
22 checks passed

wenju-he deleted the barrier-spirv-token-unsigned-to-signed branch March 19, 2025 00:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SYCL] Change SPIR-V Enum token type from unsigned int to int for barrier builtins #17438

[SYCL] Change SPIR-V Enum token type from unsigned int to int for barrier builtins #17438

wenju-he commented Mar 13, 2025 •

edited

Loading

sommerlukas left a comment

npmiller left a comment

Naghasan Mar 13, 2025

wenju-he Mar 14, 2025

uditagarwal97 left a comment

AllanZyne left a comment

wenju-he commented Mar 18, 2025

Fznamznon Mar 18, 2025

wenju-he Mar 18, 2025

frasercrmck left a comment

maksimsab left a comment •

edited

Loading

wenju-he commented Mar 19, 2025

[SYCL] Change SPIR-V Enum token type from unsigned int to int for barrier builtins #17438

[SYCL] Change SPIR-V Enum token type from unsigned int to int for barrier builtins #17438

Conversation

wenju-he commented Mar 13, 2025 • edited Loading

sommerlukas left a comment

Choose a reason for hiding this comment

npmiller left a comment

Choose a reason for hiding this comment

Naghasan Mar 13, 2025

Choose a reason for hiding this comment

wenju-he Mar 14, 2025

Choose a reason for hiding this comment

uditagarwal97 left a comment

Choose a reason for hiding this comment

AllanZyne left a comment

Choose a reason for hiding this comment

wenju-he commented Mar 18, 2025

Fznamznon Mar 18, 2025

Choose a reason for hiding this comment

wenju-he Mar 18, 2025

Choose a reason for hiding this comment

frasercrmck left a comment

Choose a reason for hiding this comment

maksimsab left a comment • edited Loading

Choose a reason for hiding this comment

wenju-he commented Mar 19, 2025

wenju-he commented Mar 13, 2025 •

edited

Loading

maksimsab left a comment •

edited

Loading