[SYCL] Fix device aspect macro header CMake dependency #17358
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch the header wasn't getting re-generated when the `.def` files are changed, which causes build failures on existing builds when new aspects are introduced.
againull
approved these changes
Mar 7, 2025
|
@intel/llvm-gatekeepers this is ready to merge Test failure is unrelated and tracked here: #17285 |
adamfidel
pushed a commit
to reble/llvm
that referenced
this pull request
Mar 11, 2025
Without this patch the header wasn't getting re-generated when the `.def` files are changed, which causes build failures on existing builds when new aspects are introduced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch the header wasn't getting re-generated when the
.deffiles are changed, which causes build failures on existing builds when new aspects are introduced.