test(inpath): improve Windows and unix test for inpath() #4933
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2928
This PR improves test coverage for the
inpath()
function by ensuring it is properly tested on both Windows and Unix-based systems. The function previously had limited coverage, particularly on Windows, where it was not correctly detecting executables inPATH
.Changes Made
Improvements to
inpath()
incve_bin_tool/util.py
:PATH
.New and Improved Test Cases in
test/test_util.py
:test_inpath_windows
PATH
environment and verifies thatinpath()
correctly finds executables (python.exe
).test_inpath_non_windows
PATH
and verifies thatinpath()
correctly detects executables with proper permissions (os.access
).test_inpath_empty_path
inpath()
returnsFalse
when thePATH
environment variable is empty.Impact
inpath()
on both Windows and Unix-based systems..exe
handling.PATH
and incorrect file permissions.How to Verify
Run the test suite to confirm functionality: