fix: test_update_ecosystems

[22f1001635]

Summary

This PR addresses the failing test in test_source_osv.py::TestSourceOSV::test_update_ecosystems caused by a mismatch between the ecosystems listed in the remote ecosystems.txt and the ecosystems obtained via gsutil. The discrepancy was primarily due to the inclusion of an invalid [EMPTY] entry in the remote file and versioned ecosystem entries (e.g. AlmaLinux:8) that need to be mapped to their parent ecosystem names.

Changes Introduced

• Invalid Entry Removal:

  • Discards the [EMPTY] entry from the set of expected ecosystems derived from ecosystems.txt.

• Manual Adjustments:

  • Adds missing parent ecosystem entries (DWF and JavaScript) in the gsutil output but not in the remote file.

• Parent Ecosystem Extraction:

  • Updates the test to extract parent ecosystem names from versioned entries by splitting on :, ensuring that entries like AlmaLinux:8 are correctly mapped to AlmaLinux.

• Performance Consideration:

  • Relying solely on the ecosystems.txt file for ecosystem selection avoids redundant downloads and duplicate JSON processing.

Checklist

• ✅ Code adheres to the project’s coding standards.
• ✅ All tests pass successfully.
• ✅ The changes are backward-compatible and consistent with OSV's intended data handling.

Steps to Test

1. Set the environment variable for external system tests:

   EXTERNAL_SYSTEM=1 pytest test/test_source_osv.py::TestSourceOSV::test_update_ecosystems
   

Verify that:

• The test passes without errors.
• The parent ecosystems extracted from the gsutil listings match the adjusted list from ecosystems.txt (with [EMPTY] removed and DWF and JavaScript added).

Related Issues
Fixes #4633

Additional Notes

• This fix assumes that the general ecosystem listing provided by ecosystems.txt is sufficient for selecting the correct ecosystems.
• The manual additions and parent extraction logic reconcile the differences between the gsutil output and the remote file, aligning with the OSV data model and improving performance.

[22f1001635]

@terriko required changes have been made please take a look