Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Add pyproject.toml #4873

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix:Add pyproject.toml #4873

wants to merge 6 commits into from

Conversation

vedpawar2254
Copy link
Contributor

@vedpawar2254 vedpawar2254 commented Mar 1, 2025

fixes #4872
I checked out this and it seems doing nothing was also an option but I added the pyproject.toml file as it was recommended, the setup.py file will work alongside pyproject.toml file

Thanks

@terriko
Copy link
Contributor

terriko commented Mar 5, 2025

We're overdue to switch to pyproject.toml and actually having one would be nice because some of our linter config could move into there I think. I'm going to update this branch to make sure we don't get any weirdness with the build test but assuming that works we may be good to go.

@vedpawar2254
Copy link
Contributor Author

HI @terriko, can you let me know more what linter config we can move in this.
Thanks !

@terriko
Copy link
Contributor

terriko commented Mar 6, 2025

Some of them have the options to store their config in pyproject.toml rather than in individual config files, I don't remember which ones off the top of my head but it's likely more of them than the last time I looked anyhow, but you can do the reading as well as I can. If you need links for the linters to look it up, they're in .pre-commit-config.yaml or listed https://github.com/intel/cve-bin-tool/blob/main/CONTRIBUTING.md#running-linters

That said, don't change this PR, linter config should be a separate change.

@vedpawar2254 vedpawar2254 changed the title fix: Add pyproject.toml fix: Add pyproject.toml Mar 7, 2025
@vedpawar2254 vedpawar2254 changed the title fix: Add pyproject.toml fix:Add pyproject.toml Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: DEPRECATION warning on pip install -e .
4 participants