Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor temporary directory handling #273

Merged
merged 6 commits into from
Mar 31, 2025
Merged

Refactor temporary directory handling #273

merged 6 commits into from
Mar 31, 2025

Conversation

harp-intel
Copy link
Contributor

@harp-intel harp-intel commented Mar 29, 2025

  • --tempdir flag overrides default (usually /tmp) in case /tmp is on a filesystem mounted with the 'noexec' option
  • improve error messages, e.g., when temp dir lands on a 'noexec' file system
  • eliminate --targettemp flag

There are two temporary directories created.

  • for the application, this is where dependencies and scripts are written before being copied to the target
  • for the target (remote or local), this is where the scripts and dependencies are stored and executed (must not be 'noexec')

Only the 2nd temporary directory location can be changed with --tempdir. The 1st always lands in the system's default temp, e.g., /tmp.

Both directories are cleaned up (removed) when the application exits...unless the --debug flag is specified.

@harp-intel harp-intel changed the title Tempdir Refactor temporary directory handling Mar 29, 2025
@harp-intel harp-intel linked an issue Mar 29, 2025 that may be closed by this pull request
@harp-intel harp-intel merged commit 48884b2 into main Mar 31, 2025
4 checks passed
@harp-intel harp-intel deleted the tempdir branch March 31, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metrics cannot be collected when /tmp is mounted with noexec
1 participant