Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show timestamps in metrics summary and telemetry charts #205

Merged
merged 2 commits into from
Feb 15, 2025
Merged

show timestamps in metrics summary and telemetry charts #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9554aaa
show timestamps in metrics summary charts
harp-intel Feb 14, 2025
371844a
change telemetry charts to line type and add timestamps in x axis
harp-intel Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cmd/metrics/resources/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,9 +263,15 @@

const base_line = {
xAxis: {
type: "category",
data: TIMESTAMPS,
name: "time (s)",
min: "dataMin",
max: "dataMax",
boundaryGap: false, // ensure the chart starts at the first data point
axisLabel: {
rotate: 45,
}
},
yAxis: {},
tooltip: {
Expand Down
20 changes: 14 additions & 6 deletions cmd/metrics/summary.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
"regexp"
"strconv"
"strings"
"time"

"perfspect/internal/util"
)
Expand Down Expand Up @@ -320,23 +321,30 @@ func (m *metricsFromCSV) getHTML(metadata Metadata) (html string, err error) {
{"PKGPOWER", []string{"package power (watts)", "package power (watts)"}},
{"DRAMPOWER", []string{"DRAM power (watts)", ""}},
}
for _, tmpl := range templateReplace {
for tIdx, tmpl := range templateReplace {
var timeStamps []string
var series [][]float64
var firstTimestamp float64
for rIdx, row := range m.rows {
if rIdx == 0 {
firstTimestamp = row.timestamp
}
if math.IsNaN(row.metrics[tmpl.metricNames[archIndex]]) || math.IsInf(row.metrics[tmpl.metricNames[archIndex]], 0) {
continue
}
series = append(series, []float64{row.timestamp - firstTimestamp, row.metrics[tmpl.metricNames[archIndex]]})
series = append(series, []float64{float64(rIdx), row.metrics[tmpl.metricNames[archIndex]]})
// format the UNIX timestamp as a local tz string
ts := time.Unix(int64(row.timestamp), 0).Format("15:04:05")
timeStamps = append(timeStamps, ts)
}
var seriesBytes []byte
if seriesBytes, err = json.Marshal(series); err != nil {
return
}
html = strings.Replace(html, tmpl.tmplVar, string(seriesBytes), -1)
if tIdx == 0 {
var timeStampsBytes []byte
if timeStampsBytes, err = json.Marshal(timeStamps); err != nil {
return
}
html = strings.Replace(html, "TIMESTAMPS", string(timeStampsBytes), -1)
}
}
// All Metrics Tab
var metricHTMLStats [][]string
Expand Down
Loading